-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[infra] #33309 automatically apply spotless #33310
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
a494564
to
cd02853
Compare
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33310 +/- ##
=========================================
Coverage 57.41% 57.41%
Complexity 1474 1474
=========================================
Files 970 970
Lines 154481 154481
Branches 1076 1076
=========================================
Hits 88701 88701
Misses 63578 63578
Partials 2202 2202 ☔ View full report in Codecov by Sentry. |
Added spotlessApply for now, I'm not familiar with the other formatting tools mentioned in the ML. |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
||
// delegate spotlessApply to :runners:flink:spotlessApply | ||
tasks.named("spotlessApply") { | ||
dependsOn ":runners:flink:spotlessApply" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this have the right source sets? I would expect the sources for each subdirectory to need its own task with the overridden source set. (and yes i see this will conflict with the top-level source set - not sure what is the best solution)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is somewhat due to how flink runner is built. Spotless is applied using :runners:flink:spotlessApply
, although the runner is built using e.g. :runners:flink:1.18:build
. This only makes the :runners:flink:spotlessApply
called automatically for all versions.
Closes #33309
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.