Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] #33309 automatically apply spotless #33310

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

je-ik
Copy link
Contributor

@je-ik je-ik commented Dec 6, 2024

Closes #33309


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@je-ik je-ik force-pushed the auto-spotless-apply branch from a494564 to cd02853 Compare December 7, 2024 16:08
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.41%. Comparing base (d379968) to head (cd02853).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #33310   +/-   ##
=========================================
  Coverage     57.41%   57.41%           
  Complexity     1474     1474           
=========================================
  Files           970      970           
  Lines        154481   154481           
  Branches       1076     1076           
=========================================
  Hits          88701    88701           
  Misses        63578    63578           
  Partials       2202     2202           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@je-ik
Copy link
Contributor Author

je-ik commented Dec 8, 2024

Added spotlessApply for now, I'm not familiar with the other formatting tools mentioned in the ML.

R: @damccorm @kennknowles

Copy link
Contributor

github-actions bot commented Dec 8, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers


// delegate spotlessApply to :runners:flink:spotlessApply
tasks.named("spotlessApply") {
dependsOn ":runners:flink:spotlessApply"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this have the right source sets? I would expect the sources for each subdirectory to need its own task with the overridden source set. (and yes i see this will conflict with the top-level source set - not sure what is the best solution)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is somewhat due to how flink runner is built. Spotless is applied using :runners:flink:spotlessApply, although the runner is built using e.g. :runners:flink:1.18:build. This only makes the :runners:flink:spotlessApply called automatically for all versions.

@je-ik je-ik merged commit e1245d9 into apache:master Dec 9, 2024
28 checks passed
@je-ik je-ik deleted the auto-spotless-apply branch December 9, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Automatic spotlessApply
2 participants