Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#32211] Fail job on SDK worker disconnect, instead of hanging forever. #33298

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Dec 5, 2024

In working on OnWindowExpiry, it shows SDK side disconnects would cause the job to hang indefinitely if there were outstanding ProcessBundleRequests.

Instead, the job should fail (as SDK disconnects are not WAI behavior), and terminate execution instead.

Not testable as a closed form Go side without a more involved set up, but obvious in certain Python and Java side test failures. Clean job termination leads to better iteration than hangs do.

Part of #32211


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck
Copy link
Contributor Author

lostluck commented Dec 5, 2024

R: @damondouglas

@lostluck lostluck requested a review from damondouglas December 5, 2024 20:32
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree that it's not so straightforward to setup this kind of test.

@lostluck lostluck merged commit 2344fdc into apache:master Dec 5, 2024
9 checks passed
@lostluck lostluck deleted the failJobOnCrash branch December 5, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants