[java] BQ: add missing avro conversions to BQ TableRow #33221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Avro float fields can be used to write BQ FLOAT columns. Add TableRow conversion for such field. Adding conversion for aveo 1.10+ logical types local-timestamp-millis and local-timestam-micros.
RustedBones
force-pushed
the
bq-avro-float
branch
from
81a60b1 to
943b361
Compare
|
Follow-up: RustedBones#108 |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damondouglas for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @damondouglas @johnjcasey |
Abacn
reviewed
Dec 6, 2024
...ogle-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryAvroUtils.java
Show resolved
Hide resolved
Abacn
reviewed
Dec 6, 2024
...-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryAvroUtilsTest.java
Show resolved
Hide resolved
|
Thanks for the change! Just had two questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33197
Add missing
avro -> BQconversions:float->INTEGERtime-millis->TIMEtimestamp-millis->TIMESTAMPlocal-timestamp-millis->DATETIMElocal-timestamp-micros->DATETIMEenum->STRINGfixed->BYTESmap->RECORDkey/valueReworked
BigQueryAvroUtilsTestto test conversions in isolation.Ideally
BigQueryAvroUtilsshould also provide a schema converteravro.Schema -> TableSchemato facilitate write of avro model to BQ