Make the model names unique and fix the tox package deps for tensorflow tests #33216
Conversation
liferoad
changed the title
| @@ -410,8 +410,9 @@ deps = | |||
| tensorflow>=2.12rc1,<2.13 | |||
| # Help pip resolve conflict with typing-extensions for old version of TF https://github.com/apache/beam/issues/30852 | |||
| pydantic<2.7 | |||
| protobuf==4.25.5 | |||
| extras = test,gcp,ml_test | |||
| extras = test,gcp | |||
There was a problem hiding this comment.
Tox honors the package deps with this order: deps -> extras -> install_requires. So if tensorflow is set several times, only the last one takes the effect. @jrmccluskey FYI.
There was a problem hiding this comment.
we remove ml-test here since these tests only rely on tensorflow.
| extras = test,gcp,ml_test | ||
| extras = test,gcp | ||
| commands_pre = | ||
| pip install -U 'protobuf==4.25.5' |
There was a problem hiding this comment.
install_requires will install protobuf with 5.x, which is not supported by tesnsorflow 2.12.x. So we reinstall protobuf with the fix version here.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
Failed tests are not related to this PR. https://github.com/apache/beam/actions/runs/12039225345/job/33566573652?pr=33216 is green now. |
Addresses #30799
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.