Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nondeterminism from expansion tests #33082

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

damccorm
Copy link
Contributor

These depend on

if subprocess_server.SubprocessServer._cache._live_owners:
which can lead to errors like:

    def test_classpath(self):
      with tempfile.TemporaryDirectory() as temp_dir:
        try:
          # Avoid having to prefix everything in our test strings.
          oldwd = os.getcwd()
          os.chdir(temp_dir)
          # Touch some files for globing.
          with open('a1.jar', 'w') as _:
            pass
    
          service = JavaJarExpansionService(
              'main.jar', classpath=['a*.jar', 'b.jar'])
>         self.assertEqual(
              service._default_args(),
              ['{{PORT}}', '--filesToStage=main.jar,a1.jar,b.jar'])
E             AssertionError: Lists differ: ['{{P[13 chars]lesToStage=main.jar,a1.jar,b.jar', '--alsoStartLoopbackWorker'] != ['{{P[13 chars]lesToStage=main.jar,a1.jar,b.jar']
E             
E             First list contains 1 additional elements.
E             First extra element 2:
E             '--alsoStartLoopbackWorker'
E             
E             - ['{{PORT}}',
E             -  '--filesToStage=main.jar,a1.jar,b.jar',
E             ?                                        ^
E             
E             + ['{{PORT}}', '--filesToStage=main.jar,a1.jar,b.jar']
E             ? ++++++++++++                                       ^
E             
E             -  '--alsoStartLoopbackWorker']

and overall flakiness like https://github.com/apache/beam/actions/workflows/beam_PreCommit_Python_Coverage.yml?query=event%3Aschedule

This removes the nondeterminism by clearing the cache.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm damccorm marked this pull request as ready for review November 11, 2024 18:39
@damccorm
Copy link
Contributor Author

R: @ahmedabu98 @jrmccluskey

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm damccorm merged commit 97ae5aa into master Nov 11, 2024
86 of 87 checks passed
@damccorm damccorm deleted the users/damccorm/nondeterminism branch November 11, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants