-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JdbcIO] Adding disableAutoCommit flag #32988
Conversation
d9dd509
to
ccd1b57
Compare
fixes #31111 |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
assign set of reviewers |
Does this also affect Jdbc write where it always set "setAutoCommit" also
|
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
Outdated
Show resolved
Hide resolved
I'm not sure as my use-case doesn't require write. But since the original change was brought only for read (#14349) I think it makes sense to bring a Write fix as a separate PR. |
r: @turb |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Looks good to me since it is a flag. I need to support it in scio though. |
thanks for the review |
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcSchemaIOProvider.java
Show resolved
Hide resolved
* unit tests * CHANGES.md * unit tests * CHANGES.md updating getDisableAutoCommit variable naming cleanup cleanup cleanup cleanup cleanup whitespace cleanup whitespace cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Will merge after tests passed
PreCommit YAML Xlang Direct - FAILED apache_beam/yaml/integration_tests.py::SpannerTest::test_only not related to this PR, likely Gradle cache issue |
Thanks for the review |
Addresses #31111
Adding flag to conditionally disable auto-commit for JdbcIO read due to current incompatibility with Informix database.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.