Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JdbcIO] Adding disableAutoCommit flag #32988

Merged
merged 3 commits into from
Nov 13, 2024
Merged

[JdbcIO] Adding disableAutoCommit flag #32988

merged 3 commits into from
Nov 13, 2024

Conversation

cwashcraft
Copy link
Contributor

@cwashcraft cwashcraft commented Oct 31, 2024

Addresses #31111

Adding flag to conditionally disable auto-commit for JdbcIO read due to current incompatibility with Informix database.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@cwashcraft cwashcraft force-pushed the master branch 3 times, most recently from d9dd509 to ccd1b57 Compare October 31, 2024 19:21
@cwashcraft cwashcraft marked this pull request as ready for review October 31, 2024 20:20
@cwashcraft
Copy link
Contributor Author

fixes #31111

@cwashcraft
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @Abacn for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@cwashcraft cwashcraft marked this pull request as draft November 1, 2024 15:27
@cwashcraft cwashcraft marked this pull request as ready for review November 1, 2024 17:37
@cwashcraft
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Reviewers are already assigned to this PR: @m-trieu @Abacn

@Abacn
Copy link
Contributor

Abacn commented Nov 5, 2024

Does this also affect Jdbc write where it always set "setAutoCommit" also

@cwashcraft
Copy link
Contributor Author

Does this also affect Jdbc write where it always set "setAutoCommit" also

I'm not sure as my use-case doesn't require write. But since the original change was brought only for read (#14349) I think it makes sense to bring a Write fix as a separate PR.

@cwashcraft
Copy link
Contributor Author

r: @turb

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@turb
Copy link
Contributor

turb commented Nov 7, 2024

Looks good to me since it is a flag. I need to support it in scio though.

@cwashcraft
Copy link
Contributor Author

Looks good to me since it is a flag. I need to support it in scio though.

thanks for the review

Chris Ashcraft added 2 commits November 12, 2024 16:03
* unit tests
* CHANGES.md

* unit tests
* CHANGES.md

updating getDisableAutoCommit

variable naming

cleanup

cleanup

cleanup

cleanup

cleanup

whitespace cleanup

whitespace cleanup
@cwashcraft cwashcraft requested a review from Abacn November 12, 2024 23:23
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Will merge after tests passed

@Abacn
Copy link
Contributor

Abacn commented Nov 13, 2024

PreCommit YAML Xlang Direct - FAILED apache_beam/yaml/integration_tests.py::SpannerTest::test_only

not related to this PR, likely Gradle cache issue

@Abacn Abacn merged commit 9394f85 into apache:master Nov 13, 2024
102 of 103 checks passed
@cwashcraft
Copy link
Contributor Author

Thank you!

Will merge after tests passed

Thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants