Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zetasql version to 2024.11.1 #32902

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Bump zetasql version to 2024.11.1 #32902

merged 1 commit into from
Nov 20, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 22, 2024

In preparation of upcoming GCP-BOM update

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Oct 22, 2024

ZetaSQL 2024.08.2 is a bad release. https://repo1.maven.org/maven2/com/google/zetasql/zetasql-client/2024.08.2/zetasql-client-2024.08.2.pom has version number 2024.08.1, causing compile failed with

> Could not resolve all dependencies for configuration ':sdks:java:extensions:sql:expansion-service:runtimeClasspath'.
   > Could not resolve com.google.zetasql:zetasql-client:2024.08.2.
     Required by:
         project :sdks:java:extensions:sql:expansion-service > project :sdks:java:extensions:sql:zetasql
      > Could not resolve com.google.zetasql:zetasql-client:2024.08.2.
         > inconsistent module metadata found. Descriptor: com.google.zetasql:zetasql-client:2024.08.1 Errors: bad version: expected='2024.08.2' found='2024.08.1'
      > Could not resolve com.google.zetasql:zetasql-client:2024.08.2.
         > inconsistent module metadata found. Descriptor: com.google.zetasql:zetasql-client:2024.08.1 Errors: bad version: expected='2024.08.2' found='2024.08.1'

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Abacn Abacn changed the title Bump zetasql version to 2024.08.2 Bump zetasql version to 2024.08.1 Oct 22, 2024
@Abacn
Copy link
Contributor Author

Abacn commented Oct 22, 2024

ZetaSQL 2022.08 release already had multiple breaking change due to removed public APIs:

Task :sdks:java:extensions:sql:hcatalog:buildDependents
/runner/_work/beam/beam/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java:500: error: cannot find symbol

> Task :sdks:java:extensions:sql:zetasql:compileJava
                                fixedOutputSchemaTVF.getOutputSchema().getColumns());
                                                    ^
  symbol:   method getOutputSchema()
  location: variable fixedOutputSchemaTVF of type FixedOutputSchemaTVF
/runner/_work/beam/beam/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/TVFScanConverter.java:74: error: cannot find symbol
            .containsKey(zetaNode.getTvf().getNamePath())) {
                                          ^
  symbol:   method getNamePath()
  location: class TableValuedFunction
/runner/_work/beam/beam/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/TVFScanConverter.java:75: error: cannot find symbol
      inputs.add(context.getUserDefinedTableValuedFunctions().get(zetaNode.getTvf().getNamePath()));
                                                                                   ^
  symbol:   method getNamePath()
  location: class TableValuedFunction
/runner/_work/beam/beam/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java:97: error: incompatible types: ResolvedComputedColumnBase cannot be converted to ResolvedComputedColumn
      for (ResolvedComputedColumn computedColumn : zetaNode.getAggregateList()) {
                                                                            ^
/runner/_work/beam/beam/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/AggregateScanConverter.java:147: error: incompatible types: ResolvedComputedColumnBase cannot be converted to ResolvedComputedColumn
    for (ResolvedComputedColumn resolvedComputedColumn : node.getAggregateList()) {
                                                                              ^

Found internally that these code were removed by bot as "dead code". Upgrading ZetaSQL is no longer not attempted as more similar breaking change may be seen if we choose this route.

@Abacn Abacn marked this pull request as draft October 23, 2024 19:31
@Abacn Abacn marked this pull request as ready for review November 19, 2024 21:22
@Abacn
Copy link
Contributor Author

Abacn commented Nov 19, 2024

@Abacn Abacn changed the title Bump zetasql version to 2024.08.1 Bump zetasql version to 2024.11.1 Nov 19, 2024
@Abacn
Copy link
Contributor Author

Abacn commented Nov 19, 2024

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor Author

Abacn commented Nov 20, 2024

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn Abacn merged commit 5d3088f into apache:master Nov 20, 2024
24 checks passed
@Abacn Abacn deleted the bumpzetasql branch November 20, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants