Enable external callers to start a WindmillStream #32763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… metric tracking.
… Future proofs this logic for direct path.
… have it implement WorkProvider interface. Move class to windmill/work/provider directory, update visibility for dependent classes and move tests, add GetWorkBudgetOwnerInterface
… have it implement WorkProvider interface. Move class to windmill/work/provider directory, update visibility for dependent classes and move tests, add GetWorkBudgetOwnerInterface
… have it implement WorkProvider interface. Move class to windmill/work/provider directory, update visibility for dependent classes and move tests, add GetWorkBudgetOwnerInterface
… WindmillEndpoints and don't process any version that is older than the current version in FanOutStreamingEngineWorkerHarness
…a_redistributesBudget()
…ady 600 seconds anyway. Move DEFAULT_STREAM_RPC_DEADLINE_SECONDS to where it is being used and remove references in tests
…e StreamingEngineConnectionsState to StreamingEngineBackends
m-trieu
force-pushed
the
mt-windmill-start
branch
from
ec9dd32 to
a655371
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
m-trieu
force-pushed
the
mt-windmill-start
branch
from
a655371 to
4861fcc
Compare
… around in an unstarted state. Start the streams in WindmillStreamSender in parallel
m-trieu
force-pushed
the
mt-windmill-start
branch
from
4861fcc to
b6045f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WindmillStreamimplementations were previously created and returned in a "started" state usually after the stream has already sent the initial headers to open the connection to the backend servers.This prevents us from being able to start the stream "lazily".
Add flexibility to the
WindmillStreamAPI by allowing external callers to start the stream themselves. This is especially important in direct path mode where the user worker manages the fan out to the backend.in terms of implementation, similar to
WindmillStream.shutdown(),WindmillStream.start()'s behavior will only execute once during the lifetime of theWindmillStreamobject. Subsequent calls tostart()will do nothing.branched off of #31902, should be merged after
changes to relevant to this PR are in commit ec9dd32
R: @scwhittle @arunpandianp
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.