[Prism] Support BundleFinalization DoFn parameter #32425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @lostluck |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
damondouglas
commented
Sep 11, 2024
lostluck
reviewed
Sep 18, 2024
lostluck
approved these changes
Sep 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32425 +/- ##
============================================
- Coverage 57.33% 57.32% -0.01%
Complexity 1474 1474
============================================
Files 964 965 +1
Lines 153301 153467 +166
Branches 1076 1076
============================================
+ Hits 87896 87981 +85
- Misses 63201 63281 +80
- Partials 2204 2205 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@lostluck The codecov/patch report shows stuff that didn't seem sensible to write tests for. Should I just go ahead and merge this you think? |
|
Agreed. Please go ahead |
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
* Support BundleFinalization DoFn parameter * Replace beam.Register with register.DoFn2x0 * Add TestParDoBundleFinalizer.* to filters * Register test funcs * Add filter to portable runner tests * Temporarily skip test * Simply tests; refactor per PR comments * Skip tests for not lookback mode * Clean up tests; add to coverage * Fix import ordering --------- Co-authored-by: Robert Burke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #31912 by adding support for bundle finalization via the
beam.BundleFinalizationDoFn parameter.With Prism running, to validate Java tests against Prism runner:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.