Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PostCommit Python sklearn on Python3.12 #32171

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix PostCommit Python sklearn on Python3.12 #32171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/trigger_files/beam_PostCommit_Python.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run."
"comment": "Modify this file in a trivial way to cause this test suite to run.",
"modification": 1
}

7 changes: 4 additions & 3 deletions sdks/python/apache_beam/examples/inference/sklearn_examples_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
#

# This should match the saved version of your trained model.
# Beam's tests use sklearn 1.0.2 for their saved models.
# Beam's tests use saved models with sklearn 1.0.2, which supports py3.7-3.10
# However, newer sklearn is needed for testing on newer Python version
scikit-learn==1.0.2; python_version < '3.11'
# https://github.com/apache/beam/issues/27151 sklearn support Py311 in 1.2
scikit-learn==1.2.2; python_version >= '3.11'
# bump sklearn version when new Python version is supported
scikit-learn==1.3.1; python_version >= '3.11'
Loading