Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up google-cloud-storage version to fix data corruption issue #32135

Merged

Conversation

shunping
Copy link
Contributor

@shunping shunping commented Aug 9, 2024

The data corruption issue has been fixed since google-resumable-media-2.7.2 (googleapis/google-resumable-media-python#451), and it is now covered in google-cloud-storage-2.8.2 (googleapis/python-storage#1339).

fixes #32169


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@shunping
Copy link
Contributor Author

shunping commented Aug 9, 2024

@damccorm

@github-actions github-actions bot removed the docker label Aug 9, 2024
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll merge once checks pass

@@ -440,7 +440,7 @@ def get_portability_package_data():
'google-cloud-datastore>=2.0.0,<3',
'google-cloud-pubsub>=2.1.0,<3',
'google-cloud-pubsublite>=1.2.0,<2',
'google-cloud-storage>=2.16.0,<3',
'google-cloud-storage>=2.18.2,<3',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for others who come across this - this got bumped in a previous pr for our containers -

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic.

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know the range of beam versions affected? Was the upstream bug always there since gcs migration?

@shunping
Copy link
Contributor Author

shunping commented Aug 9, 2024

Do we know the range of beam versions affected? Was the upstream bug always there since gcs migration?

Beam version between 2.53.0 and 2.58.0 are affected by this problem, and yes, the upstream bug had been there since gcsio migration.

The bug was introduced two years ago at googleapis/google-resumable-media-python#294, which was then released as version google-resumable-media-2.3.0.

We had our GcsIO migration at Beam release 2.53.0 (8ac8b20) and introduced the new dependency of google-cloud-storage-2.10.0, which depends on google-resumable-media-2.3.2. (https://github.com/googleapis/python-storage/blob/v2.10.0/setup.py#L34C6-L34C37).

@damccorm damccorm merged commit cae9148 into apache:master Aug 9, 2024
91 of 92 checks passed
@shunping shunping deleted the update-google-cloud-storage-version branch August 9, 2024 15:04
@tvalentyn
Copy link
Contributor

tvalentyn commented Aug 9, 2024

Beam version between 2.53.0 and 2.58.0 are affected by this problem, and yes, the upstream bug had been there since gcsio migration.

Let's document this in an issue, see examples:

#30867 (comment)
#28246 (comment)

@shunping
Copy link
Contributor Author

Beam version between 2.53.0 and 2.58.0 are affected by this problem, and yes, the upstream bug had been there since gcsio migration.

Let's document this in an issue, see examples:

#30867 (comment) #28246 (comment)

Thanks! Added #32169.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [Python SDK] Data Corruption on GCS read in 2.53.0 - 2.58.0 SDKs.
4 participants