-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prism] Use non-deprecated docker types in environment. #32092
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32092 +/- ##
==========================================
Coverage 58.67% 58.67%
Complexity 3025 3025
==========================================
Files 1121 1121
Lines 172734 172850 +116
Branches 3275 3275
==========================================
+ Hits 101350 101421 +71
- Misses 68083 68123 +40
- Partials 3301 3306 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [prism] Use non-deprecated docker types in environment. * Include Go mod changes. * Update testcontainers-go * revert toolchain change * go mod tidy requirement, update minimum Go version. * Note Minimum Go version update. --------- Co-authored-by: lostluck <[email protected]>
Attempt 2 in updating the docker configuration types to their non-deprecated versions.
This is to unblock updating to v27 of the docker libraries which removes the deprecated aliases.
Deps updates also require moving to go 1.21, so that change is happening here as well.
See #32059.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.