Remove auth@1 in tests running on self hosted runner #31881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It's causing "invalid JWT Signature" issue
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
acrites
pushed a commit
to acrites/beam
that referenced
this pull request
Jul 17, 2024
* It's causing "invalid JWT Signature" issue
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
* It's causing "invalid JWT Signature" issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Performance tests part of #31848
These tests all uses io-datastores k8s instances, previously authenticate with GHA secret. However, either the secret becomes invalid or the auth action has problems, causing "invalid JWT Signature" issue
These tests are running on self-hosted runners in the same GCP project with io-datastores instance, and the credential is in place, no need to auth again.
Please add a meaningful description for your change here
Example run:
Jdbc Performance test: https://github.com/apache/beam/actions/runs/9914644914
HDFS Performance test: https://github.com/apache/beam/actions/runs/9915736828
SparkReceiver Performance test: https://github.com/apache/beam/actions/runs/9915739255
IO_Iceberg tests has the same issue:
https://github.com/apache/beam/actions/runs/9906366268/job/27367796375
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.