Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python test auth #31850

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Fix Python test auth #31850

merged 4 commits into from
Jul 11, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jul 11, 2024

tested: https://github.com/apache/beam/actions/runs/9894928466

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Jul 11, 2024
@Abacn
Copy link
Contributor Author

Abacn commented Jul 11, 2024

R: @damccorm

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn
Copy link
Contributor Author

Abacn commented Jul 11, 2024

This change replaced the deprecated setup-gcloud@v0 to auth@v1 for the following tests:

python test (fixed): https://github.com/apache/beam/actions/runs/9894928466

java test (fixed): https://github.com/apache/beam/actions/runs/9895714192

typescript test (permared): https://github.com/apache/beam/actions/runs/9895711562

build and version runner docker image (already passing): https://github.com/apache/beam/actions/runs/9895728848

This fixes current breakage on python test. Also tried to fix build_wheels and cleanUpGcpResource, not able to get them to work so reverted

@Abacn
Copy link
Contributor Author

Abacn commented Jul 11, 2024

The reason build_wheel not work but python test worked was because the latter is running on self hosted runner, which comes with credential even not run auth action

auth@v1 works for dataflow runner authentication but seems not effective for gsutil auth

@Abacn
Copy link
Contributor Author

Abacn commented Jul 11, 2024

R: @ahmedabu98

@Abacn Abacn merged commit 441840a into master Jul 11, 2024
4 checks passed
@Abacn Abacn deleted the tryfixpythontest branch July 12, 2024 20:06
acrites pushed a commit to acrites/beam that referenced this pull request Jul 17, 2024
* Fix Python test auth

* Replace more places setup-gcloud@v0 -> auth@v1

* add setup cloud

* Revert change on build_wheels
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
* Fix Python test auth

* Replace more places setup-gcloud@v0 -> auth@v1

* add setup cloud

* Revert change on build_wheels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants