Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include everit_json_schema in schemaio expansion service uber jar (#30779) #30823

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Apr 1, 2024

Cherrypick for patch release


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm
Copy link
Contributor Author

damccorm commented Apr 1, 2024

R: @kennknowles @Abacn

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.52%. Comparing base (0dc330e) to head (0dc330e).

❗ Current head 0dc330e differs from pull request most recent head fe9bbb1. Consider uploading reports for the commit fe9bbb1 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.55.1   #30823   +/-   ##
===============================================
  Coverage           38.52%   38.52%           
===============================================
  Files                 698      698           
  Lines              102371   102371           
===============================================
  Hits                39441    39441           
  Misses              61297    61297           
  Partials             1633     1633           
Flag Coverage Δ
go 54.32% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damccorm damccorm merged commit e9422c2 into release-2.55.1 Apr 2, 2024
19 checks passed
@damccorm damccorm deleted the users/damccorm/everit-cp branch April 2, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants