Include byte size of stateKey in estimated weight of WindmillBag, WindmillValue, and WindmillWatermarkHold #30654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include byte size of the stateKey on the BagState weight used to estimate and limit the total state cache size
Include stateKey size in the byte size of a WidnmillValue
Include keyState size in the WatermarkHold estimated byte size
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
arunpandianp
approved these changes
Mar 15, 2024
|
From precommit logs it appears the tests need to be updated |
|
R: @scwhittle fixed the test, thank you for pointing to it, still learning workflows for Beam on GitHub. The test is inherently fragile, but I'm not sure how to improve it without major rework. |
unrelated flaky test |
Abacn
approved these changes
Mar 18, 2024
Abacn
pushed a commit
to Abacn/beam
that referenced
this pull request
Mar 18, 2024
…dmillValue, and WindmillWatermarkHold (apache#30654) * Update WindmillBag.java Include byte size of the stateKey on the BagState weight used to estimate and limit the total state cache size * Update WindmillValue.java Include stateKey size in the byte size of a WidnmillValue * Update WindmillWatermarkHold.java Include keyState size in the WatermarkHold estimated byte size * Fix formatting issue * Fix expected cache item weights in WindmillStateInternalsTest
Abacn
added a commit
that referenced
this pull request
Mar 18, 2024
…dmillValue, and WindmillWatermarkHold (#30654) (#30665) * Update WindmillBag.java Include byte size of the stateKey on the BagState weight used to estimate and limit the total state cache size * Update WindmillValue.java Include stateKey size in the byte size of a WidnmillValue * Update WindmillWatermarkHold.java Include keyState size in the WatermarkHold estimated byte size * Fix formatting issue * Fix expected cache item weights in WindmillStateInternalsTest Co-authored-by: dmitryor <[email protected]>
hjtran
pushed a commit
to hjtran/beam
that referenced
this pull request
Apr 4, 2024
…dmillValue, and WindmillWatermarkHold (apache#30654) * Update WindmillBag.java Include byte size of the stateKey on the BagState weight used to estimate and limit the total state cache size * Update WindmillValue.java Include stateKey size in the byte size of a WidnmillValue * Update WindmillWatermarkHold.java Include keyState size in the WatermarkHold estimated byte size * Fix formatting issue * Fix expected cache item weights in WindmillStateInternalsTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include byte size of stateKey in estimated weight of WindmillBag, WindmillValue, and WindmillWatermarkHold
The weight is used to track and limit the total StateCache memory size. For certain workloads stateKey consitutes major portion of total memory pinned by cache entries. Not including it into the weight results in severe underestimate of the real cache size, and may leads to GC thrashing and eventually to workers crashing OOM.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.