Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Any environment types before optimization. #30568

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Mar 8, 2024

This allows us to correctly inspect environment capabilities during optimization, etc.

This should fix #28972


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

This allows us to correctly inspect environment capabilities during optimization, etc.
@github-actions github-actions bot added the python label Mar 8, 2024
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Tested locally that test passed. It decodes windows correctly:

<class 'apache_beam.coders.coder_impl.IntervalWindowCoderImpl'> ([0.0, 10.0),)
<class 'apache_beam.coders.coder_impl.IntervalWindowCoderImpl'> ([10.0, 20.0),)
<class 'apache_beam.coders.coder_impl.IntervalWindowCoderImpl'> ([20.0, 30.0),)
<class 'apache_beam.coders.coder_impl.IntervalWindowCoderImpl'> ([0.0, 10.0),)
<class 'apache_beam.coders.coder_impl.IntervalWindowCoderImpl'> ([10.0, 20.0),)
<class 'apache_beam.coders.coder_impl.IntervalWindowCoderImpl'> ([20.0, 30.0),)

Previously it was bytes (see #28972 (comment))

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit 3f8af4b into apache:master Mar 8, 2024
71 checks passed
@Abacn
Copy link
Contributor

Abacn commented Mar 8, 2024

Let me add a cherry-pick PR for this to fix permared postcommit on release branch

Abacn pushed a commit to Abacn/beam that referenced this pull request Mar 8, 2024
This allows us to correctly inspect environment capabilities during optimization, etc.
Abacn added a commit that referenced this pull request Mar 8, 2024
This allows us to correctly inspect environment capabilities during optimization, etc.

Co-authored-by: Robert Bradshaw <[email protected]>
hjtran pushed a commit to hjtran/beam that referenced this pull request Apr 4, 2024
This allows us to correctly inspect environment capabilities during optimization, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: beam_PostCommit_XVR_Direct perma-red.
2 participants