Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all tour examples from part 1 #30478

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix all tour examples from part 1 #30478

merged 1 commit into from
Mar 25, 2024

Conversation

Dal-Papa
Copy link
Contributor

@Dal-Papa Dal-Papa commented Mar 4, 2024

Fix all the Go examples for the Tour of Beam all the way until "Core Transformations". A subsequent PR will fix the rest of the examples.

beam.Init was missing on all the files making it impossible to run in the Playground.
Also, go fmt format wasn't respected on a lot of the files.

This fixes #30477 (partly)

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @johnjcasey added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Dal-Papa
Copy link
Contributor Author

Dal-Papa commented Mar 9, 2024

R: @lostluck

Copy link
Contributor

github-actions bot commented Mar 9, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@lostluck
Copy link
Contributor

Only just saw this today. The original ping happened while I was on a boat. Thank you for your patience. Taking a look now.

Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was straightforward. Thank you very much for going ahead and fixing these!

@lostluck lostluck merged commit c8ad120 into apache:master Mar 25, 2024
2 checks passed
hjtran pushed a commit to hjtran/beam that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Tour examples are not running
2 participants