Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python PostCommit BigQuery JSON #30438

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Fix Python PostCommit BigQuery JSON #30438

merged 3 commits into from
Feb 28, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Feb 27, 2024

Fixes #30437

This is the same fix of the java counterpart of #29923

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Feb 27, 2024
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label python.
R: @damccorm for label build.
R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor Author

Abacn commented Feb 27, 2024

There are failed tests in
:sdks:python:test-suites:direct:py310:hdfsIntegrationTestFAILED 2m 28.267s

However the dataflow test is fixed:

:sdks:python:test-suites:dataflow:py310:postCommitIT 1h 40m 58.810s

@Abacn
Copy link
Contributor Author

Abacn commented Feb 27, 2024

R: @ahmedabu98

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for fixing this

@Abacn Abacn merged commit 2bebb27 into apache:master Feb 28, 2024
72 of 76 checks passed
@Abacn Abacn deleted the fixbqjsontest branch February 28, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Python Postcommits are continuously failing
2 participants