-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Vertex AI Feature Store enrichment handler #30388
Conversation
2d0376c
to
56349f3
Compare
56349f3
to
f44eef6
Compare
f44eef6
to
8cc428a
Compare
8cc428a
to
8962b2f
Compare
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
R: @damccorm / @tvalentyn (since Anand and Jack are OOO). Let's get it in for 2.55.0 |
sdks/python/apache_beam/transforms/enrichment_handlers/vertex_ai_feature_store.py
Show resolved
Hide resolved
sdks/python/apache_beam/transforms/enrichment_handlers/vertex_ai_feature_store.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/transforms/enrichment_handlers/vertex_ai_feature_store.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/transforms/enrichment_handlers/vertex_ai_feature_store.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/transforms/enrichment_handlers/vertex_ai_feature_store.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/transforms/enrichment_handlers/vertex_ai_feature_store.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/transforms/enrichment_handlers/vertex_ai_feature_store.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/transforms/enrichment_handlers/vertex_ai_feature_store.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like test failure is unrelated, so I'm good to merge as long as we have an issue to track the open comment
Unrelated failure/flake. Merging this. |
This PR adds support for Vertex AI Feature Store with Bigtable online serving and legacy feature store.
It builds on top of the #30001 that added the handler for Bigtable.
Example:
The Optimized Serving and Vector Retrieval are in preview launch from Vertex AI which uses the
aiplatform_v1beta
version of library. Once these are launched from beta, I'll update the client to use that library.Nothing should change for the user-interface but just the internal of handler where we set up and call the client. I tried this with beta library and it works but I would prefer to not depend on beta library at this point. We will need a different handler for Vector Retrieval case but Optimized Serving can be covered with the existing
VertexAIFeatureStoreEnrichmentHandler
.Part of #30386
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.