Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing credentials from pipeline options into SpannerIO.readChangeStream #30361

Merged
merged 13 commits into from
Feb 29, 2024

Conversation

dengwe1
Copy link
Contributor

@dengwe1 dengwe1 commented Feb 21, 2024

Fix an issue with SpannerIO.readChangeStream() where the pipeline credential (provided in the pipeline options) is not being used by the initial getDialect call, which can result in an UNAUTHENTICATED error when accessing Spanner.

The changes include:

  • Support setting credentials in SpannerConfig.
  • In SpannerIO.readChangeStream(), if no credential is set in SpannerConfig, use the credential from the pipeline options for authenticating with Spanner.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@dengwe1
Copy link
Contributor Author

dengwe1 commented Feb 21, 2024

R: @nancyxu123

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@dengwe1
Copy link
Contributor Author

dengwe1 commented Feb 21, 2024

assign set of reviewers

@dengwe1
Copy link
Contributor Author

dengwe1 commented Feb 27, 2024

assign set of reviewers

@liferoad
Copy link
Collaborator

Please update CHANGES.md.

@dengwe1
Copy link
Contributor Author

dengwe1 commented Feb 28, 2024

Please update CHANGES.md.

Done.

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, will merge once get lgtm from reviewer @nancyxu123

CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: Yi Hu <[email protected]>
@nancyxu123
Copy link
Contributor

LGTM

@Abacn Abacn merged commit c5e1d10 into apache:master Feb 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants