Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JSON type in TableSchema for WriteToBigQuery with FILE_LOAD method in Python SDK #30340

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Conversation

sapphire008
Copy link
Contributor

@sapphire008 sapphire008 commented Feb 18, 2024

Removing the JSON type check when using WriteToBigQuery with FILE_LOAD method in Python SDK. Throwing a warning instead.

  • Related to the change in Java SDK: Allow JSON type in TableSchema for BigQuery FILE_LOAD #29923. Consistent with this PR for Java SDK, I have changed the raise ValueError to a logging.warn`.
  • Relevant lines of code
    def find_in_nested_dict(schema):
    for field in schema['fields']:
    if field['type'] == 'JSON':
    raise ValueError(
    'Found JSON type in table schema. JSON data '
    'insertion is currently not supported with '
    'FILE_LOADS write method. This is supported with '
    'STREAMING_INSERTS. For more information: '
    'https://cloud.google.com/bigquery/docs/reference/'
    'standard-sql/json-data#ingest_json_data')
    elif field['type'] == 'STRUCT':
    find_in_nested_dict(field)
    find_in_nested_dict(self.schema)

I did some hackish testing against a table of my own and it was able to insert the json fields correctly without a problem.

NOT RECOMMENDED but it solves the problem for those who need this tomorrow:

In my docker file that has Apache Beam installed, I used sed to replace the check:

RUN sed -i 's/if field\['\''type'\''\] == '\''JSON'\'':/if field\['\''type'\''\] == '\''JSON_IS_OKAY'\'':/g' /usr/local/lib/python3.11/site-packages/apache_beam/io/gcp/bigquery.py

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.
R: @bvolpato for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn merged commit e00a81f into apache:master Feb 20, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants