sickbay new reshuffle test on runners that do not support it #29994
Conversation
kennknowles
force-pushed
the
reshuffle-sickbay
branch
from
3a1867f to
2141d5b
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
There was a problem hiding this comment.
Spark3 streaming portable VR test excluded here: https://github.com/apache/beam/blob/2141d5b24b0a3373fa04703c19921758b3a4ca26/runners/spark/job-server/spark_job_server.gradle#L155C106-L155C106
runners/spark/spark_runner.gradle
Outdated
| @@ -420,6 +422,8 @@ tasks.register("validatesStructuredStreamingRunnerBatch", Test) { | |||
| excludeTestsMatching 'org.apache.beam.sdk.transforms.FlattenTest.testFlattenMultipleCoders' | |||
| // SDF | |||
| excludeTestsMatching 'org.apache.beam.sdk.transforms.SplittableDoFnTest.testLifecycleMethodsBounded' | |||
| // TODO(https://github.com/apache/beam/issues/29973) | |||
| excludeTestsMatching 'org.apache.beam.sdk.transforms.ReshuffleTest.testReshufflePreservesMetadata' | |||
There was a problem hiding this comment.
This is for StructuredStreaming VR PostCommit, which is failing for another reason: https://github.com/apache/beam/actions/runs/7501119957/job/20421142433 but testReshufflePreservesMetadata can pass: https://ge.apache.org/s/dvx6wng372byy/tests/overview
kennknowles
force-pushed
the
reshuffle-sickbay
branch
from
2141d5b to
fefeb6e
Compare
|
Green - after LGTM I will remove the commit with the trigger files. |
kennknowles
force-pushed
the
reshuffle-sickbay
branch
from
fefeb6e to
cf20119
Compare
|
Removed trigger files. Will merge after confirming that default tests remain green. |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Mitigates #29973 but I will leave the issue open because the tests are just being disabled because the runners do not preserve reshuffle metadata
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.