Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#29180][prism] Return total element count to progress loop. Split less aggressively. #29968

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Jan 10, 2024

Return the total element count to the progress loop, and use as part of the split computation.

This avoids prism being hyper aggressive at splitting SDFs, and but still splits a bundle when stuck.

While out of scope for this PR, the total element count will monotonically increase during the bundle's lifetime, and will indicate if any progress is being made in the bundle, not simply at the root transform. (Within Beam's domain of course, since we don't have a way to measure external progress.) eg. We could track the progress at the last few ticks and only split if progress dips below our estimated progress.

Fixes #29180


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck lostluck changed the title [prism] Return total element count to progress loop. Split less aggre… [prism] Return total element count to progress loop. Split less aggressively. Jan 10, 2024
@lostluck lostluck mentioned this pull request Jan 10, 2024
16 tasks
@lostluck lostluck changed the title [prism] Return total element count to progress loop. Split less aggressively. [#29180][prism] Return total element count to progress loop. Split less aggressively. Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6066af3) 38.23% compared to head (86cd617) 38.23%.
Report is 13 commits behind head on master.

Files Patch % Lines
...beam/runners/prism/internal/jobservices/metrics.go 75.00% 3 Missing ⚠️
...pkg/beam/runners/prism/internal/jobservices/job.go 0.00% 1 Missing ⚠️
sdks/go/pkg/beam/runners/prism/internal/stage.go 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #29968   +/-   ##
=======================================
  Coverage   38.23%   38.23%           
=======================================
  Files         696      696           
  Lines      101879   101889   +10     
=======================================
+ Hits        38953    38961    +8     
- Misses      61309    61311    +2     
  Partials     1617     1617           
Flag Coverage Δ
go 53.94% <78.26%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lostluck lostluck marked this pull request as ready for review January 11, 2024 23:55
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@lostluck
Copy link
Contributor Author

Thanks for the review!

@lostluck lostluck merged commit 0d58d23 into apache:master Jan 12, 2024
11 checks passed
@lostluck lostluck deleted the reduceSplittingAggressiveness branch January 12, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][prism]: Excessive Splitting
2 participants