-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#29180][prism] Return total element count to progress loop. Split less aggressively. #29968
[#29180][prism] Return total element count to progress loop. Split less aggressively. #29968
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29968 +/- ##
=======================================
Coverage 38.23% 38.23%
=======================================
Files 696 696
Lines 101879 101889 +10
=======================================
+ Hits 38953 38961 +8
- Misses 61309 61311 +2
Partials 1617 1617
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Thanks for the review! |
Return the total element count to the progress loop, and use as part of the split computation.
This avoids prism being hyper aggressive at splitting SDFs, and but still splits a bundle when stuck.
While out of scope for this PR, the total element count will monotonically increase during the bundle's lifetime, and will indicate if any progress is being made in the bundle, not simply at the root transform. (Within Beam's domain of course, since we don't have a way to measure external progress.) eg. We could track the progress at the last few ticks and only split if progress dips below our estimated progress.
Fixes #29180
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.