Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#29848][Go SDK] Fix exec side transform identification. #29842

Merged
merged 8 commits into from
Jan 2, 2024

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Dec 20, 2023

Fix exec side transform identification using the global transformID and not the "UniqueName". The error occurred prior to the FnAPI becoming solid ~4 years ago, or sufficient understanding to root case it at the time.

The Go SDK has been "refering" to transforms incorrectly when communicating back to the runner, which largely affects things like metrics. This was noticable in state and timers since only Dataflow implemented additional translations to the Go SDK approach, which was to use the "UniqueName" from the transforms.

This fix allows enabling additional tests against Spark and Flink runners for state and timers, and presumably fixes handling of metrics.

Pre-cursor to #29772, since it doesn't make sense to try and maintain the transform identification name handling error in Prism, as it's aiming to be a fairly model single machin Portable runner.

Fixes #29848


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

Reminder, please take a look at this pr: @riteshghorse @Abacn

@lostluck lostluck changed the title DO NOT SUBMIT - testing transform ID fix. [#29772][Go SDK] Fix exec side transform identification. Dec 28, 2023
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (783c72a) 38.23% compared to head (fac12b1) 38.23%.

Files Patch % Lines
sdks/go/pkg/beam/core/runtime/exec/translate.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #29842      +/-   ##
==========================================
- Coverage   38.23%   38.23%   -0.01%     
==========================================
  Files         696      696              
  Lines      101881   101881              
==========================================
- Hits        38956    38953       -3     
- Misses      61311    61313       +2     
- Partials     1614     1615       +1     
Flag Coverage Δ
go 53.93% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lostluck lostluck changed the title [#29772][Go SDK] Fix exec side transform identification. [#29848][Go SDK] Fix exec side transform identification. Dec 28, 2023
@lostluck
Copy link
Contributor Author

R: @damondouglas if convenient.

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck merged commit 9f7ab3a into apache:master Jan 2, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Go SDK uses PTransform UniqueName as key instead of the global PID for a transform.
2 participants