-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#29848][Go SDK] Fix exec side transform identification. #29842
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @riteshghorse @Abacn |
75694cf
to
0e5eee0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29842 +/- ##
==========================================
- Coverage 38.23% 38.23% -0.01%
==========================================
Files 696 696
Lines 101881 101881
==========================================
- Hits 38956 38953 -3
- Misses 61311 61313 +2
- Partials 1614 1615 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
R: @damondouglas if convenient. |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix exec side transform identification using the global transformID and not the "UniqueName". The error occurred prior to the FnAPI becoming solid ~4 years ago, or sufficient understanding to root case it at the time.
The Go SDK has been "refering" to transforms incorrectly when communicating back to the runner, which largely affects things like metrics. This was noticable in state and timers since only Dataflow implemented additional translations to the Go SDK approach, which was to use the "UniqueName" from the transforms.
This fix allows enabling additional tests against Spark and Flink runners for state and timers, and presumably fixes handling of metrics.
Pre-cursor to #29772, since it doesn't make sense to try and maintain the transform identification name handling error in Prism, as it's aiming to be a fairly model single machin Portable runner.
Fixes #29848
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.