Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a Fully Managed Beam Streaming System with Flink Runner on Kubernetes - Part 2 #29794

Merged

Conversation

talatuyarer
Copy link
Contributor

Hi all,

I created part 2 of the blog post. Could you review this ?

Thanks


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@talatuyarer
Copy link
Contributor Author

Hi
@rszper and @damondouglas Could you review my part 2 blog post ? After this I will also share last part How to build Autoscaling for Apache Beam Job sections. I am working on it.

@damondouglas damondouglas self-requested a review December 18, 2023 17:38
@damondouglas
Copy link
Contributor

@talatuyarer Thank you again for doing this! I will be happy to review this.

@talatuyarer
Copy link
Contributor Author

@talatuyarer Thank you again for doing this! I will be happy to review this.

Thank you @damondouglas I look forward your comments.

Copy link
Contributor

@rszper rszper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm learning so much!

@talatuyarer
Copy link
Contributor Author

I'm learning so much!

Thank you so much @rszper. I a m learning so much from your comments too

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @rszper for label website.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@rszper rszper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, mostly minor. Otherwise, looks good.

Copy link
Contributor

@rszper rszper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@talatuyarer
Copy link
Contributor Author

@rszper and @damondouglas I will it is ready to publish. If you dont have anything. I addressed all @rszper 's suggestions

Copy link
Contributor

R: @melap for final approval

@damondouglas
Copy link
Contributor

Thank you for all your help and comments, @rszper! I see the bot assigned @melap for final approval. Is there a suggested approval I don't know about or can we go ahead and squash/merge?

My only non-blocking comment is for those who learn by doing, it would be great if there were published Kubernetes manifests or step-by-step guide for someone to replicate the environment setup discussed in this blog. I remember part 1 has the Deployment manifest but I'm not sure this is enough nor have I tried on my own Kubernetes cluster.

@damondouglas damondouglas merged commit 7342b03 into apache:master Dec 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants