Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding failure_mode parameter to Spanner Python transforms #29529

Merged
merged 4 commits into from
Dec 2, 2023

Conversation

pabloem
Copy link
Member

@pabloem pabloem commented Nov 24, 2023

r: @johnjcasey ? : )

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b6e19eb) 37.86% compared to head (2bf5002) 37.86%.
Report is 1 commits behind head on master.

Files Patch % Lines
sdks/python/apache_beam/io/gcp/spanner.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #29529      +/-   ##
==========================================
- Coverage   37.86%   37.86%   -0.01%     
==========================================
  Files         690      690              
  Lines      101352   101356       +4     
==========================================
  Hits        38381    38381              
- Misses      61377    61381       +4     
  Partials     1594     1594              
Flag Coverage Δ
python 29.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.
R: @kennknowles for label java.
R: @johnjcasey for label io.
R: @nielm for label spanner.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@nielm
Copy link
Contributor

nielm commented Nov 24, 2023

Approved pending pre-commit checks passing.

@pabloem pabloem merged commit 6593a0f into apache:master Dec 2, 2023
97 of 98 checks passed
@pabloem pabloem deleted the pabloem-spanner-failure-mode branch December 2, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants