Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dsl-euphoria] #29451 deprecate Euphoria DSL #29452

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

je-ik
Copy link
Contributor

@je-ik je-ik commented Nov 16, 2023

Closes #29451


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@je-ik
Copy link
Contributor Author

je-ik commented Nov 16, 2023

R: aromanenko-dev
R: dmvk

@je-ik
Copy link
Contributor Author

je-ik commented Nov 16, 2023

R: JozoVilcek

@je-ik je-ik requested review from dmvk and aromanenko-dev November 16, 2023 09:05
@je-ik je-ik force-pushed the 29451-deprecate-euphoria branch from 801ef82 to 1dce59d Compare November 16, 2023 09:06
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@je-ik je-ik force-pushed the 29451-deprecate-euphoria branch from 1dce59d to 17e8794 Compare November 16, 2023 14:06
@je-ik je-ik force-pushed the 29451-deprecate-euphoria branch from 17e8794 to f9b9d9a Compare November 16, 2023 14:38
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @bvolpato for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@bvolpato bvolpato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@je-ik je-ik merged commit f618969 into apache:master Nov 16, 2023
20 checks passed
@je-ik je-ik deleted the 29451-deprecate-euphoria branch November 16, 2023 15:15
@aromanenko-dev
Copy link
Contributor

aromanenko-dev commented Nov 16, 2023

Thanks! LGTM too

Just a minor notice - I'd recommend to add a note about this deprecation into CHANGES.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Deprecate Euphoria extension
3 participants