-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a Fully Managed Beam Streaming System with Flink Runner on Kubernetes #29305
Creating a Fully Managed Beam Streaming System with Flink Runner on Kubernetes #29305
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This looks great! Thanks for doing this. cc @damccorm |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
R: @rszper |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a nit.
website/www/site/content/en/blog/apache-beam-flink-and-kubernetes.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/apache-beam-flink-and-kubernetes.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider my question non-blocking of the PR. Is the intent for the reader to follow this article to replicate in their own environment?
Thank you reviewing @damondouglas Our goal is to share experience while building this system. and Show readers it is possible with some few challenges. Whoever wants to build similar system. I believe they can see different issue also too. I can write a tutorial after Part 2 step by step how they can build based on open source examples. |
website/www/site/content/en/blog/apache-beam-flink-and-kubernetes.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/apache-beam-flink-and-kubernetes.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/apache-beam-flink-and-kubernetes.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/apache-beam-flink-and-kubernetes.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/apache-beam-flink-and-kubernetes.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/apache-beam-flink-and-kubernetes.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/apache-beam-flink-and-kubernetes.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/apache-beam-flink-and-kubernetes.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/apache-beam-flink-and-kubernetes.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is resolved:
Thank you again for this really helpful blog! Pardon if this comment is already addressed, but I saw what might be the cause of the failing checks. It seems both failed checks point to the one error.
I see: ERROR Author 'talat' is not defined. Please add them to 'website/www/site/data/authors.yml'
at https://github.com/apache/beam/actions/runs/6788979982/job/18455154941?pr=29305#step:6:2861
I will check in tomorrow (2023-11-08 PST time zone) to see the status of this PR and review again to assess any resolution of existing comments and pre-commit checks. Thank you for your patience and your contribution. I look forward to trying this out myself.
…tes.md Co-authored-by: Rebecca Szper <[email protected]>
…tes.md Co-authored-by: Rebecca Szper <[email protected]>
…tes.md Co-authored-by: Rebecca Szper <[email protected]>
…tes.md Co-authored-by: Rebecca Szper <[email protected]>
…tes.md Co-authored-by: Rebecca Szper <[email protected]>
…tes.md Co-authored-by: Rebecca Szper <[email protected]>
…tes.md Co-authored-by: Rebecca Szper <[email protected]>
…tes.md Co-authored-by: Rebecca Szper <[email protected]>
…tes.md Co-authored-by: Rebecca Szper <[email protected]>
…tes.md Co-authored-by: Rebecca Szper <[email protected]>
Co-authored-by: Rebecca Szper <[email protected]>
I believe we cleared all issues but Looks like pictures are very blur. I will change pictures. |
@damondouglas Please review it. I updated images and fixed all issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking: This image looks a bit small. You can decide to keep it or remove it since you already have the FlinkDeployment manifest as a code snippet. Therefore, my comment is non-blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thank you so much.
Hi all,
We created a blog post for Apache beam about how we created a managed service for our Beam jobs on Kubernetes. First part is about General Architecture details. I am also working on challenges and learning on part2. I hope you can publish this blog post on Beam Blog. I believe this will be helpful for another who wants to build similar system.
Thanks
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.