-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Python PreCommit GHA recommendations_ai teardown #29067
Conversation
@@ -70,9 +70,12 @@ def extract_prediction(response): | |||
recommendationengine is None, | |||
"Recommendations AI dependencies not installed.") | |||
class RecommendationAIIT(unittest.TestCase): | |||
test_ran = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test_ran needs to be a class variable to be accessed in tearDownClass
Codecov Report
@@ Coverage Diff @@
## master #29067 +/- ##
==========================================
- Coverage 38.39% 38.39% -0.01%
==========================================
Files 686 686
Lines 101640 101652 +12
==========================================
Hits 39028 39028
- Misses 61032 61044 +12
Partials 1580 1580
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
While we should fix the permission on self-hosted runner, this IT class should not be executed for unit tests including its teardownClass |
Fixes #29054
This test has been permared on GHA but actually due to an issue on the test itself. The teardownClass is always attempted and fail if missing gcp permission, even though all test cases skipped.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.