Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python PreCommit GHA recommendations_ai teardown #29067

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Oct 18, 2023

Fixes #29054

This test has been permared on GHA but actually due to an issue on the test itself. The teardownClass is always attempted and fail if missing gcp permission, even though all test cases skipped.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@@ -70,9 +70,12 @@ def extract_prediction(response):
recommendationengine is None,
"Recommendations AI dependencies not installed.")
class RecommendationAIIT(unittest.TestCase):
test_ran = False
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_ran needs to be a class variable to be accessed in tearDownClass

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #29067 (f836059) into master (695dd41) will decrease coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #29067      +/-   ##
==========================================
- Coverage   38.39%   38.39%   -0.01%     
==========================================
  Files         686      686              
  Lines      101640   101652      +12     
==========================================
  Hits        39028    39028              
- Misses      61032    61044      +12     
  Partials     1580     1580              
Flag Coverage Δ
python 30.00% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...n/apache_beam/ml/gcp/recommendations_ai_test_it.py 65.45% <50.00%> (-8.02%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor Author

Abacn commented Oct 19, 2023

While we should fix the permission on self-hosted runner, this IT class should not be executed for unit tests including its teardownClass

@Abacn Abacn merged commit d25905e into apache:master Oct 19, 2023
71 of 73 checks passed
@Abacn Abacn deleted the fixprecommit branch October 19, 2023 13:57
kkdoon pushed a commit to twitter-forks/beam that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: Python Precommits Failing with "Cloud IAM check failed"
2 participants