Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML] Schemify avroio and add a yaml provider. #28855

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Oct 5, 2023

This fixes #28852


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@robertwb
Copy link
Contributor Author

robertwb commented Oct 6, 2023

R: @riteshghorse

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #28855 (07e26fd) into master (5d6dcee) will decrease coverage by 0.02%.
Report is 60 commits behind head on master.
The diff coverage is 71.03%.

@@            Coverage Diff             @@
##           master   #28855      +/-   ##
==========================================
- Coverage   72.21%   72.20%   -0.02%     
==========================================
  Files         684      684              
  Lines      101241   101371     +130     
==========================================
+ Hits        73116    73196      +80     
- Misses      26546    26596      +50     
  Partials     1579     1579              
Flag Coverage Δ
python 82.72% <71.03%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/pvalue.py 91.11% <100.00%> (+0.03%) ⬆️
sdks/python/apache_beam/typehints/schemas.py 88.97% <100.00%> (+0.06%) ⬆️
sdks/python/apache_beam/yaml/yaml_provider.py 64.18% <60.00%> (-0.13%) ⬇️
sdks/python/apache_beam/io/avroio.py 82.64% <70.58%> (-15.61%) ⬇️

... and 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@robertwb
Copy link
Contributor Author

robertwb commented Oct 6, 2023

Run Portable_Python PreCommit

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Left some comments but nothing blocking.

sdks/python/apache_beam/io/avroio.py Show resolved Hide resolved
sdks/python/apache_beam/io/avroio.py Show resolved Hide resolved
@robertwb robertwb merged commit ce217d3 into apache:master Oct 6, 2023
76 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yaml] Normalize AvroIO
3 participants