-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flink Runner] Add UseDataStreamForBatch option to Flink runner to enable batch execution on DataStream API #28614
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Tests are failing while publishing results which seems unrelated to those changes... |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @kennknowles |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @kennknowles added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @kennknowles |
Modify the FlinkRunner to use DataStream API for batch job execution if UseDataStreamForBatch is set to true.
DataStream execution path of batch jobs.
Hey @tvalentyn ! |
…rProcessingTimeContinuationTriggerUsingState
It appears this change may also caused Flink ValidatesRunner to became extremely flaky: https://github.com/apache/beam/actions/workflows/beam_PostCommit_Java_ValidatesRunner_Flink.yml?page=6&query=event%3Aschedule Although this test suite has always been flaky (~30% fail rate), prior to Oct 27th it became extremely flaky (<5% success rate) Some example errors:
|
…able batch execution on DataStream API (apache#28614) Co-authored-by: Jiangjie Qin <[email protected]> Co-authored-by: tvalentyn <[email protected]>
…er to enable batch execution on DataStream API (apache#28614)" This reverts commit 1f7e882.
…able batch execution on DataStream API (apache#28614) Co-authored-by: Jiangjie Qin <[email protected]> Co-authored-by: tvalentyn <[email protected]>
This PR is just #25742 updated. It also include the changes in #28609 which should be merged first.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.