Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make launcher method public in Load test base classes. #28568

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Make launcher method public in Load test base classes. #28568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/IOLoadTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public void tearDownBase() throws IOException {
}

@Override
PipelineLauncher launcher() {
public PipelineLauncher launcher() {
return DefaultPipelineLauncher.builder(CREDENTIALS).build();
}

Expand Down
2 changes: 1 addition & 1 deletion it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/LoadTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public void tearDownLoadTestBase() throws IOException {
monitoringClient.cleanupAll();
}

abstract PipelineLauncher launcher();
public abstract PipelineLauncher launcher();

/**
* Exports the metrics of given dataflow job to BigQuery.
Expand Down
Loading