Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inplace argument from set_axis for Pandas 2 #28536

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

caneff
Copy link
Contributor

@caneff caneff commented Sep 19, 2023

One more removed_args that I missed before.

Umbrella issue: #27221

@caneff
Copy link
Contributor Author

caneff commented Sep 19, 2023

R: @tvalentyn

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #28536 (535bcaa) into master (71c68ca) will increase coverage by 0.03%.
Report is 14 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #28536      +/-   ##
==========================================
+ Coverage   72.22%   72.25%   +0.03%     
==========================================
  Files         684      684              
  Lines      100883   100949      +66     
==========================================
+ Hits        72865    72944      +79     
+ Misses      26441    26428      -13     
  Partials     1577     1577              
Flag Coverage Δ
python 82.86% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/apache_beam/dataframe/frames.py 95.37% <100.00%> (+<0.01%) ⬆️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@caneff
Copy link
Contributor Author

caneff commented Sep 19, 2023

R: @tvalentyn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
Copy link
Contributor

LGTM

@tvalentyn tvalentyn merged commit f2a0c76 into apache:master Sep 19, 2023
3 checks passed
@caneff caneff deleted the set_axis branch September 21, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants