Remove internal series.append call from frames.py #28499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @tvalentyn |
caneff
force-pushed
the
remove_internal_append
branch
from
017f591 to
b73bf43
Compare
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
caneff
force-pushed
the
remove_internal_append
branch
from
b73bf43 to
dcea154
Compare
Codecov Report
@@ Coverage Diff @@
## master #28499 +/- ##
==========================================
- Coverage 72.34% 72.33% -0.02%
==========================================
Files 682 683 +1
Lines 100536 100749 +213
==========================================
+ Hits 72737 72873 +136
- Misses 26221 26298 +77
Partials 1578 1578
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tvalentyn
approved these changes
Sep 18, 2023
|
Run Python PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the one remaining Pandas append call for Pandas 2 compatability.
Partially fixes #27221