-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Document]: HealthcareApiClient
methods.
#28482
[Document]: HealthcareApiClient
methods.
#28482
Conversation
R: @Abacn for committer review |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Test Results1 750 tests +1 708 1 580 ✔️ +1 538 13m 28s ⏱️ + 9m 17s Results for commit 6990f02. ± Comparison against base commit ec422db. This pull request removes 42 and adds 1750 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Spotless error: |
whoops. should be fixed in new commit. |
Run Java_GCP_IO_Direct PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #28415.
Several methods are undocumented in the
HealthcareApiClient
. We should document these parameters for better user experience, given that the user will not have access to the client libraries being used under the hood.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.