Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make frame_base.py work with kwonly args for Pandas 2 #28417

Closed
wants to merge 0 commits into from

Conversation

caneff
Copy link
Contributor

@caneff caneff commented Sep 12, 2023

Most args of most methods in Pandas 2 are now kwonly. Updated frame_base.py to utilize those when doing args_to_kwargs and populate_defaults.

Also update frame.py for the few places where something is called with a positional argument that needs to be keyword in Pandas 2.

Partially fixing #27221

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #28417 (64d0c77) into master (bec94d9) will decrease coverage by 0.03%.
Report is 35 commits behind head on master.
The diff coverage is 87.27%.

@@            Coverage Diff             @@
##           master   #28417      +/-   ##
==========================================
- Coverage   72.33%   72.30%   -0.03%     
==========================================
  Files         682      683       +1     
  Lines      100536   100644     +108     
==========================================
+ Hits        72719    72775      +56     
- Misses      26239    26291      +52     
  Partials     1578     1578              
Flag Coverage Δ
python 82.81% <87.27%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/apache_beam/dataframe/frames.py 95.37% <86.95%> (+0.04%) ⬆️
sdks/python/apache_beam/dataframe/frame_base.py 89.45% <87.50%> (-0.13%) ⬇️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant