adding nightly publish #28255
adding nightly publish #28255
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28255 +/- ##
==========================================
- Coverage 72.29% 72.29% -0.01%
==========================================
Files 678 678
Lines 99911 99911
==========================================
- Hits 72233 72232 -1
- Misses 26112 26113 +1
Partials 1566 1566
Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| @@ -458,10 +460,14 @@ class BeamModulePlugin implements Plugin<Project> { | |||
|
|
|||
| project.ext.mavenGroupId = 'org.apache.beam' | |||
|
|
|||
| // Automatically use the official release version if we are performing a release | |||
| // otherwise append '-SNAPSHOT' | |||
| project.version = '2.51.0' | |||
There was a problem hiding this comment.
these changes / removing this line possibly caused internal import failure @damccorm
Was this intended / or can we add it back?
There was a problem hiding this comment.
This also caused the version number of some test became 2.51.0-SNAPSHOT-SNAPSHOT e.g. validate runner tests
There was a problem hiding this comment.
This might also be what is causing the nightly snapshot to fail too
There was a problem hiding this comment.
I'm not sure that we actually need it for the snapshots to work
Adds nightly publish workflow.
Added isNightly gradle parameter to facilitate timestamp versioning
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.