Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#24789] Add message for new prism users, in case of failures that might have worked on direct runner. #27886

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Aug 7, 2023

If a BeamGo test user has been relying on the direct runner, they might encounter failures when upgrading to 2.50. This message is for when prism is used as the default runner, and that the runner may not have been intentionally prism.

This avoids hiding the error received, and allows time pressed users to have a quick bandaid for their test failures.

We'll keep this message around for several releases, at which point it will be removed.

Fixes #24789.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the go label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #27886 (4ba4755) into master (3b112e8) will decrease coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##           master   #27886      +/-   ##
==========================================
- Coverage   70.86%   70.86%   -0.01%     
==========================================
  Files         861      861              
  Lines      105010   105020      +10     
==========================================
+ Hits        74413    74418       +5     
- Misses      29038    29041       +3     
- Partials     1559     1561       +2     
Flag Coverage Δ
go 53.70% <54.54%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/go/pkg/beam/testing/ptest/ptest.go 54.79% <54.54%> (-0.77%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lostluck lostluck changed the title [#24789] Add message for new prism users, in case of direct runner failures. [#24789] Add message for new prism users, in case of failures that might have worked on direct runner. Aug 8, 2023
@lostluck lostluck merged commit 07f32a2 into apache:master Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request][Go SDK] Replace Go Direct Runner with a Portable Runner
2 participants