-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradle command not found error for Python ValidatesContainer Dataflow ARM #27810
Conversation
Run Python ValidatesContainer Dataflow ARM 3.10 |
Codecov Report
@@ Coverage Diff @@
## master #27810 +/- ##
==========================================
- Coverage 70.88% 70.86% -0.02%
==========================================
Files 861 861
Lines 105005 105002 -3
==========================================
- Hits 74437 74414 -23
- Misses 29009 29029 +20
Partials 1559 1559
Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Python ValidatesContainer Dataflow ARM 3.11 |
Run Python ValidatesContainer Dataflow ARM |
@@ -49,15 +49,16 @@ concurrency: | |||
|
|||
jobs: | |||
beam_Python_ValidatesContainer_Dataflow_ARM: | |||
name: beam_Python_ValidatesContainer_Dataflow_ARM | |||
name: beam_Python_ValidatesContainer_Dataflow_ARM (Run Python ValidatesContainer Dataflow ARM 3.x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we remove 3.x from the name and trigger commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed what was done here:
name: beam_PreCommit_Python_Integration (Run Python_Integration PreCommit 3.x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we do need to specify matrix element. then, it's intentional. nvm.
env: | ||
MULTIARCH_TAG: ${{ env.MULTIARCH_TAG }} | ||
USER: github-actions | ||
-Ppush-containers \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the last line-joining intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just followed what was done here:
-PpythonVersion=${{ matrix.python_version }} \ |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.