Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle command not found error for Python ValidatesContainer Dataflow ARM #27810

Merged
merged 9 commits into from
Aug 2, 2023

Conversation

celeste-zeng
Copy link
Contributor

  • Updated yml file Python ValidatesContainer Dataflow ARM to fix gradle command not found error
  • Add comments and else if condition for CPU architecture argument for the validatescontainer script.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@celeste-zeng
Copy link
Contributor Author

celeste-zeng commented Aug 2, 2023

Run Python ValidatesContainer Dataflow ARM 3.10

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #27810 (025efa3) into master (e03a14c) will decrease coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #27810      +/-   ##
==========================================
- Coverage   70.88%   70.86%   -0.02%     
==========================================
  Files         861      861              
  Lines      105005   105002       -3     
==========================================
- Hits        74437    74414      -23     
- Misses      29009    29029      +20     
  Partials     1559     1559              
Flag Coverage Δ
go 53.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@celeste-zeng
Copy link
Contributor Author

Run Python ValidatesContainer Dataflow ARM 3.11

@tvalentyn
Copy link
Contributor

Run Python ValidatesContainer Dataflow ARM

@@ -49,15 +49,16 @@ concurrency:

jobs:
beam_Python_ValidatesContainer_Dataflow_ARM:
name: beam_Python_ValidatesContainer_Dataflow_ARM
name: beam_Python_ValidatesContainer_Dataflow_ARM (Run Python ValidatesContainer Dataflow ARM 3.x)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove 3.x from the name and trigger commands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed what was done here:

name: beam_PreCommit_Python_Integration (Run Python_Integration PreCommit 3.x)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we do need to specify matrix element. then, it's intentional. nvm.

env:
MULTIARCH_TAG: ${{ env.MULTIARCH_TAG }}
USER: github-actions
-Ppush-containers \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the last line-joining intentional?

Copy link
Contributor Author

@celeste-zeng celeste-zeng Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just followed what was done here:

-PpythonVersion=${{ matrix.python_version }} \
But it shouldn't matter either way?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@tvalentyn tvalentyn merged commit 4d49529 into apache:master Aug 2, 2023
@celeste-zeng celeste-zeng deleted the gh-py-fix branch August 3, 2023 18:05
@celeste-zeng celeste-zeng restored the gh-py-fix branch August 3, 2023 18:05
@celeste-zeng celeste-zeng deleted the gh-py-fix branch August 3, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants