[prism] Fusion base, reshuffle, cogbk. #27737
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
R: @jrmccluskey |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #27737 +/- ##
==========================================
+ Coverage 70.89% 70.91% +0.02%
==========================================
Files 860 860
Lines 104631 104852 +221
==========================================
+ Hits 74173 74358 +185
- Misses 28904 28935 +31
- Partials 1554 1559 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
ping (polite) |
| if len(t.GetOutputs()) != 1 { | ||
| panic("Expected single putput PCollection in reshuffle: " + prototext.Format(t)) | ||
| } | ||
| if len(t.GetOutputs()) != 1 { | ||
| panic("Expected single putput PCollection in reshuffle: " + prototext.Format(t)) | ||
| } |
There was a problem hiding this comment.
Looks like you missed the input check here and didn't update the panic string for each
There was a problem hiding this comment.
lol. putput. Good catch!
Add support to prism for handling reshuffles, and cogbk.
See #27550 and #24789.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.