Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --dataflowEndpoint a public option #27693

Merged
merged 4 commits into from
Jul 27, 2023
Merged

Make --dataflowEndpoint a public option #27693

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa685b0
moved --dataflowEndpoint to public pipeline option set
BjornPrime Jul 26, 2023
06ff272
minor linting
BjornPrime Jul 26, 2023
03da178
imported Dataflow to DataflowPipelineOptions
BjornPrime Jul 26, 2023
4578165
added Override decorators
BjornPrime Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
*/
package org.apache.beam.runners.dataflow.options;

import com.google.api.services.dataflow.Dataflow;
import java.util.List;
import java.util.Map;
import org.apache.beam.runners.dataflow.DataflowRunner;
Expand Down Expand Up @@ -136,6 +137,25 @@ public interface DataflowPipelineOptions

void setRegion(String region);

/**
* Dataflow endpoint to use.
*
* <p>Defaults to the current version of the Google Cloud Dataflow API, at the time the current
* SDK version was released.
*
* <p>If the string contains "://", then this is treated as a URL, otherwise {@link
* #getApiRootUrl()} is used as the root URL.
*/
@Description(
"The URL for the Dataflow API. If the string contains \"://\", this"
+ " will be treated as the entire URL, otherwise will be treated relative to apiRootUrl.")
@Override
@Default.String(Dataflow.DEFAULT_SERVICE_PATH)
String getDataflowEndpoint();

@Override
void setDataflowEndpoint(String value);

/** Labels that will be applied to the billing records for this job. */
@Description("Labels that will be applied to the billing records for this job.")
Map<String, String> getLabels();
Expand Down