-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Python INFO logging verbosity at start-up #27577
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27577 +/- ##
==========================================
- Coverage 71.14% 71.14% -0.01%
==========================================
Files 861 861
Lines 104560 104570 +10
==========================================
+ Hits 74393 74398 +5
- Misses 28618 28623 +5
Partials 1549 1549
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Python_Examples PreCommit |
Run Python_Integration PreCommit |
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
This has caused #27641, specifically this line: TBH it's hard to diagnose, because container startup logs are not available on Jenkins. |
Hmm that's strange. @Abacn what's wrong with the -q directive to that pip invocation? |
I ran the test locally and print the command, see the following log:
|
I put update: there are two invocations I see. Need fix both. The problem is the |
Root caused, will open a PR for this |
SGTM, send it to me when it's ready |
* Reduce Python INFO logging verbosity at start-up * Formatting
Makes two changes to Python worker start-up logging to reduce the verbosity of INFO logs:
This reduces the noisy boilerplate logging that happens during these steps but still surfaces errors that occur.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.