Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prism] Align side input coders & fix progress + split hang #27572

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

lostluck
Copy link
Contributor

Improvements to prism.

  • Fixes the coder side inputs use WRT reading to match what was written to the runner. They wouldn't match if the coder needed to be replaced, so a synthetic PCollection is added with the new coder for the SDK to lookup and be able to correctly decode the elements sent over the SDK.
  • Fixes a halting problem when a ProcessBundle request fails. SDK Errors on progress reporting, and Splits now abort future progress reports and splits for that bundle. This was making some tests run to timeout.
  • Remove extra logging of bundle failures. A sibling change makes failures report properly to the SDK via the JobManangment API where they can be properly logged as well.

See #27550 and #24789.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #27572 (5e2aea5) into master (b2e00ef) will decrease coverage by 0.02%.
The diff coverage is 42.35%.

@@            Coverage Diff             @@
##           master   #27572      +/-   ##
==========================================
- Coverage   71.14%   71.12%   -0.02%     
==========================================
  Files         861      861              
  Lines      104560   104603      +43     
==========================================
+ Hits        74389    74400      +11     
- Misses      28621    28647      +26     
- Partials     1550     1556       +6     
Flag Coverage Δ
go 53.62% <42.35%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...o/pkg/beam/runners/prism/internal/worker/bundle.go 51.64% <0.00%> (-4.98%) ⬇️
...am/runners/prism/internal/engine/elementmanager.go 82.09% <42.85%> (-0.74%) ⬇️
sdks/go/pkg/beam/runners/prism/internal/stage.go 84.49% <50.98%> (-4.85%) ⬇️
...o/pkg/beam/runners/prism/internal/worker/worker.go 47.72% <53.84%> (+0.78%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@riteshghorse riteshghorse merged commit 2c59a74 into apache:master Jul 20, 2023
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants