Various release script fixes #27548
Merged
Various release script fixes #27548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove Release_Gradle_Build job from release verification * Fix publish docker image script to work with remotely built images * Change empty file to .json to make RAT_PreCommit happy * Set base branch to the release branch for build snapshot PR * Bump pubsub signal wait for pipeline start to 8 min in integration tests * Change message head from Warning to Level for PubsubInjector as it follows by an exit(1)
|
pylint appears non-deterministic? failed on this PR, added a fix. |
Codecov Report
@@ Coverage Diff @@
## master #27548 +/- ##
=======================================
Coverage 71.14% 71.14%
=======================================
Files 861 861
Lines 104547 104561 +14
=======================================
+ Hits 74385 74395 +10
- Misses 28613 28617 +4
Partials 1549 1549
Flags with carried forward coverage won't be shown. Click here to find out more. see 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
damccorm
approved these changes
Jul 19, 2023
bvolpato
approved these changes
Jul 19, 2023
|
SpannerIT flake not related, merging for now |
aleksandr-dudko
pushed a commit
to aleksandr-dudko/beam
that referenced
this pull request
Jul 19, 2023
* Various release script fixes * Remove Release_Gradle_Build job from release verification * Fix publish docker image script to work with remotely built images * Change empty file to .json to make RAT_PreCommit happy * Set base branch to the release branch for build snapshot PR * Bump pubsub signal wait for pipeline start to 8 min in integration tests * Change message head from Warning to Level for PubsubInjector as it follows by an exit(1) * Fix Pylint
cushon
pushed a commit
to cushon/beam
that referenced
this pull request
May 24, 2024
* Various release script fixes * Remove Release_Gradle_Build job from release verification * Fix publish docker image script to work with remotely built images * Change empty file to .json to make RAT_PreCommit happy * Set base branch to the release branch for build snapshot PR * Bump pubsub signal wait for pipeline start to 8 min in integration tests * Change message head from Warning to Level for PubsubInjector as it follows by an exit(1) * Fix Pylint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various minor issue encountered in 2.49.0 release process
Fixes #27521
Fixes #27315
Fixes #27320
Remove Release_Gradle_Build job from release verification
See discussion in [Failing Test]: beam_Release_Gradle_Build permared #27320
Fix publish docker image script to work with remotely built images
Tested locally (add echo before the docker push):
Otherwise PreCommit_RAT job will fail. json is explicitly excluded from license check:
beam/build.gradle.kts
Line 98 in 62a8087
If cut the release using github action, the auto-generated pull request used for start_snapshot_build default base branch is master. This would then build next version snapshot. The base branch should be release-2.xx.0, as in the release verification PR generated here:
beam/release/src/main/scripts/verify_release_build.sh
Line 145 in 62a8087
The flakinesses reported in #27315 are due to worker startup > 5 min. It usually takes 4-6 min depending on the staging bandwidths, 8 min should suffice.
Even when this exit(1) hit, the program exits quitely but the validation script still runs and validation fails with no data written. This should be an Error.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.