Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SuppressWarnings from NoopLock.java #27416

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,17 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.locks.Condition;
import java.util.concurrent.locks.Lock;
import javax.annotation.Nonnull;
import org.checkerframework.checker.nullness.qual.NonNull;
import org.checkerframework.checker.nullness.qual.Nullable;

/**
* A lock which can always be acquired. It should not be used when a proper lock is required, but it
* is useful as a performance optimization when locking is not necessary but the code paths have to
* be shared between the locking and the non-locking variant.
*/
@SuppressWarnings({
"nullness" // TODO(https://github.com/apache/beam/issues/20497)
})
public class NoopLock implements Lock, Serializable {

private static NoopLock instance;
private static @Nullable NoopLock instance;

public static NoopLock get() {
if (instance == null) {
Expand All @@ -56,16 +54,15 @@ public boolean tryLock() {
}

@Override
public boolean tryLock(long time, @Nonnull TimeUnit unit) {
public boolean tryLock(long time, @NonNull TimeUnit unit) {
damondouglas marked this conversation as resolved.
Show resolved Hide resolved
return true;
}

@Override
public void unlock() {}

@Nonnull
@Override
public Condition newCondition() {
public @NonNull Condition newCondition() {
damondouglas marked this conversation as resolved.
Show resolved Hide resolved
throw new UnsupportedOperationException("Not implemented");
}
}