Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly link the license to Keras dependency #26712

Merged
merged 2 commits into from
May 16, 2023
Merged

Explicitly link the license to Keras dependency #26712

merged 2 commits into from
May 16, 2023

Conversation

tvalentyn
Copy link
Contributor

Keras recently changed release tooling and now their wheel doesn't have the license file in the previous location, so pip-licenses doesn't fetch it.

This fixes: https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont_with_RC/ suite.

@tvalentyn
Copy link
Contributor Author

Run Python RC Dataflow ValidatesContainer

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @liferoad for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor Author

Run Python RC Dataflow ValidatesContainer

@tvalentyn
Copy link
Contributor Author

R: @damccorm

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

damccorm
damccorm approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvalentyn tvalentyn merged commit cea0f6c into master May 16, 2023
@tvalentyn tvalentyn deleted the tvalentyn-patch-4 branch May 16, 2023 13:50
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
@tvalentyn @cushon
Explicitly link the license to Keras dependency (apache#26712)
d8b36bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damccorm damccorm damccorm approved these changes

Assignees
No one assigned
Labels
docker Next Action: Reviewers python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tvalentyn @damccorm