Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pandas to <=1.5.3 for Interactive #26377

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Pin pandas to <=1.5.3 for Interactive #26377

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b4d3d2
Pin pandas
liferoad Apr 21, 2023
9f96860
remove python version
liferoad Apr 21, 2023
2efda0c
make interactive requires dataframe
liferoad Apr 21, 2023
963ae9c
fix the error
liferoad Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions sdks/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,14 @@ def cythonize(*args, **kwargs):
else:
pyarrow_dependency = 'pyarrow>=3.0.0,<12.0.0'

# Exclude pandas<=1.4.2 since it doesn't work with numpy 1.24.x.
# Exclude 1.5.0 and 1.5.1 because of
# https://github.com/pandas-dev/pandas/issues/45725
dataframe_dependency = [
'pandas<1.6.0;python_version=="3.7"',
'pandas>=1.4.3,!=1.5.0,!=1.5.1,<1.6;python_version>="3.8"',
],
liferoad marked this conversation as resolved.
Show resolved Hide resolved


# We must generate protos after setup_requires are installed.
def generate_protos_first():
Expand Down Expand Up @@ -326,7 +334,7 @@ def get_portability_package_data():
# https://github.com/jupyter/jupyter_client/issues/637
'jupyter-client>=6.1.11,!=6.1.13,<8.1.1',
'timeloop>=1.0.2,<2',
],
] + dataframe_dependency,
'interactive_test': [
# notebok utils
'nbformat>=5.0.5,<6',
Expand All @@ -343,13 +351,7 @@ def get_portability_package_data():
'azure-core>=1.7.0,<2',
'azure-identity>=1.12.0,<2',
],
# Exclude pandas<=1.4.2 since it doesn't work with numpy 1.24.x.
# Exclude 1.5.0 and 1.5.1 because of
# https://github.com/pandas-dev/pandas/issues/45725
'dataframe': [
'pandas<1.6.0;python_version=="3.7"',
'pandas>=1.4.3,!=1.5.0,!=1.5.1,<1.6;python_version>="3.8"',
],
'dataframe': dataframe_dependency,
'dask': [
'dask >= 2022.6',
'distributed >= 2022.6',
Expand Down