Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace StorageV1 client with GCS client #25965

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Replace StorageV1 client with GCS client #25965

merged 1 commit into from
Jun 30, 2023

Conversation

BjornPrime
Copy link
Contributor

Addresses #25676.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@BjornPrime
Copy link
Contributor Author

stop reviewer notifications

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: requested by reviewer

@github-actions github-actions bot added docker and removed docker labels Mar 27, 2023
@BjornPrime
Copy link
Contributor Author

Run Python PreCommit

johnjcasey
johnjcasey reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@johnjcasey johnjcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so much simpler to read, I love it

sdks/python/apache_beam/io/gcp/gcsio.py Show resolved Hide resolved
sdks/python/apache_beam/io/gcp/gcsio.py Outdated Show resolved Hide resolved
@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

5 similar comments
@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@github-actions github-actions bot added the build label Apr 12, 2023
@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

3 similar comments
@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@github-actions github-actions bot removed the build label Apr 13, 2023
@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

2 similar comments
@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.10 PostCommit

@github-actions github-actions bot removed the twister2 label Jun 28, 2023
@BjornPrime BjornPrime force-pushed the replace-storage-client branch from 0b92fe9 to f0233a2 Compare June 28, 2023 21:10
@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

5 similar comments
@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime
Copy link
Contributor Author

Run Python 3.11 PostCommit

@BjornPrime BjornPrime force-pushed the replace-storage-client branch from d7f5b7c to 31e3cd1 Compare June 30, 2023 19:10
Abacn
Abacn approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! WIll merge once test passed

@Abacn Abacn merged commit 34a1796 into apache:master Jun 30, 2023
@BjornPrime BjornPrime mentioned this pull request Jul 5, 2023
Closed
15 tasks
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 7, 2023
@BjornPrime @aleksandr-dudko
Replace StorageV1 client with GCS client (apache#25965)
b2d358a
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 7, 2023
@BjornPrime @aleksandr-dudko
Replace StorageV1 client with GCS client (apache#25965)
35d078f
damccorm added a commit that referenced this pull request Jul 7, 2023
@damccorm
Revert "Replace StorageV1 client with GCS client (#25965)"
f35d836 
This reverts commit 34a1796.
@damccorm damccorm mentioned this pull request Jul 7, 2023
Merged
damccorm added a commit that referenced this pull request Jul 7, 2023
@damccorm
Revert "Replace StorageV1 client with GCS client (#25965)" (#27388)
7ce2d00 
This reverts commit 34a1796.
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 10, 2023
@BjornPrime @aleksandr-dudko
Replace StorageV1 client with GCS client (apache#25965)
26cea80
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 10, 2023
@damccorm @aleksandr-dudko
Revert "Replace StorageV1 client with GCS client (apache#25965)" (apa…
aa6db5e 
…che#27388)

This reverts commit 34a1796.
BjornPrime added a commit to BjornPrime/my-beam that referenced this pull request Jul 13, 2023
@BjornPrime
Revert "Revert "Replace StorageV1 client with GCS client (apache#25965)…
74a29fd 
…" (apache#27388)"

This reverts commit 7ce2d00.
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 17, 2023
@BjornPrime @aleksandr-dudko
Replace StorageV1 client with GCS client (apache#25965)
38a66f2
aleksandr-dudko pushed a commit to aleksandr-dudko/beam that referenced this pull request Jul 17, 2023
@damccorm @aleksandr-dudko
Revert "Replace StorageV1 client with GCS client (apache#25965)" (apa…
3ad7907 
…che#27388)

This reverts commit 34a1796.
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
@BjornPrime @cushon
Replace StorageV1 client with GCS client (apache#25965)
5893f53
cushon pushed a commit to cushon/beam that referenced this pull request May 24, 2024
@damccorm @cushon
Revert "Replace StorageV1 client with GCS client (apache#25965)" (apa…
ed44839 
…che#27388)

This reverts commit 34a1796.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjcasey johnjcasey johnjcasey left review comments

@tvalentyn tvalentyn tvalentyn left review comments

@liferoad liferoad liferoad left review comments

@Abacn Abacn Abacn approved these changes

Assignees
No one assigned
Labels
docker examples gcp io python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BjornPrime @Abacn @tvalentyn @liferoad @johnjcasey