-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MetricsContainer support to the Flink sources. #25753
Conversation
@xinyuiscool Would you help take a look? Thanks! |
3a57e31
to
4e383d2
Compare
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn added as fallback since no labels match configuration Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @Abacn |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @Abacn |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @Abacn |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @Abacn |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @Abacn |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @Abacn |
@becketqin are you still interested in submitting this change? I'd recommend reaching out on @dev and ask folks who are familiar with FlinkRunner codebase to help take a look. |
Reminder, please take a look at this pr: @Abacn |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @Abacn |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn added as fallback since no labels match configuration Available commands:
|
Reminder, please take a look at this pr: @Abacn |
ping on this. Thanks! |
Hey there! |
hey @jto, thanks for reaching out. unfortunately I haven't heard from the original author - if you or someone else can take over the PRs, it might be a path to get the change unblocked. In addition to an author, we will need a reviewer who is familiar with the codebase or is willing to dig in to take more ownership in the flink runner codebase. You could also be a reviewer, then, we will need a committer for the merge but I this point I think we are looking for review to complete. reaching out to dev@ may be an avenue to get help. |
Hey @tvalentyn ! Thanks for your reply. I think either one of my colleague or myself will take over those two PRs :) |
This patch is a follow-up patch for the Flink runner migration from DataSet API to DataStream API. It adds support for MetricsContainer which exposes the metrics defined in Beam metrics via the Flink metric framework.
fixes #25741
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.